[Webkit-unassigned] [Bug 73957] Repaint video controls when buffering during pause.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 5 17:44:34 PST 2012


Dale Curtis <dalecurtis at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #121142|                            |commit-queue?
               Flag|                            |

--- Comment #16 from Dale Curtis <dalecurtis at chromium.org>  2012-01-05 17:44:33 PST ---
(From update of attachment 121142)
View in context: https://bugs.webkit.org/attachment.cgi?id=121142&action=review

>> Source/WebCore/html/shadow/MediaControlRootElement.h:115
>> +    void bufferingProgressed();
> Nit: As WebKit being under influence of Obj-C, generally this would be named didBufferingProgress().

Thanks for your review! Since other methods in the class with similar functionality do not use the did* style, I think it's better to keep it as it is.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list