[Webkit-unassigned] [Bug 50312] Assertion failure in WebCore::HTMLFrameElementBase::insertedIntoDocument()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50312





--- Comment #16 from Eric Seidel <eric at webkit.org>  2012-01-05 14:44:00 PST ---
I originally wrote the following:

// Loads may cause synchronous javascript execution (e.g. beforeload or
// src=javascript), which could try to access the renderer before the normal
// parser machinery would call lazyAttach() and set us as needing style
// resolve.  Any code which expects this to be attached will resolve style
// before using renderer(), so this will make sure we attach in time.
if (!renderer()) {
    // This recalc is unecessary if we already have a renderer, as can be the case
    // if an earlier element's insertedIntoDocument() already forced a style recalc.
    // FIXME: Normally lazyAttach marks the renderer as attached(), but we don't
    // want to do that here, as as callers expect to call attach() right after
    // this and attach() will ASSERT(!attached())
    lazyAttach(DoNotSetAttached);
}

But I've since modified the code to just remove this lazyAttach.  As far as I can tell, it's unnecessary.  Unfortunately the tests are not behaving well on my machine, so I can't be 100% sure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.