[Webkit-unassigned] [Bug 64468] WIN: DumpRenderTree hangs under NRWT

Thu Jan 5 12:58:11 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=64468

--- Comment #22 from Adam Roben (:aroben) <aroben at apple.com>  2012-01-05 12:58:11 PST ---
(In reply to comment #21)
> (In reply to comment #18)
> > (In reply to comment #14)
> > Does Driver know whether it's running under Cygwin or not? I didn't think it did.
> >
> 
> It certainly could know if it needed it ...
> 
> > > By that same logic, test_to_uri() is only used by the chromium Driver (and various pieces of test code), and should probably be moved out of the Port object and down into the chromium Driver.
> > 
> > It's also used by WebKitPort._command_from_driver_input, of course!
> 
> right :) Even so, this should probably be on the Driver class and not the port class if nothing outside of Drivers need it.

I don't think I understand your proposal well enough to implement it myself. Any chance you'd be willing to take a stab at it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.