[Webkit-unassigned] [Bug 64468] WIN: DumpRenderTree hangs under NRWT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64468





--- Comment #18 from Adam Roben (:aroben) <aroben at apple.com>  2012-01-05 12:24:02 PST ---
(In reply to comment #14)
> (In reply to comment #13)
> > Your proposed change in comment 7 isn't quite right: tests in http/tests/local are supposed to be loaded as local files, not as http: URLs. At least according to Port.test_to_uri.
> >
> 
> Oh. Hm. You're right. That's bad, as it means the logic in controllers/manager.py is broken, and we should probably create an is_http_test() to actually codify/fix this.

Sounds good to me! I think http/tests/websocket/tests/local is supposed to be run locally too.

> > I'm trying to come up with a good name for the concept of "path to test that the driver will understand" as opposed to "path to test that Python will understand". If we had such a name, we could have a Port.test_to_<name> function that would generate the right type of path.
> 
> "path to test that the driver will understand" is probably only actually used under Driver.run_test(), so I'm not sure if there's value in creating a separate routine for it (at least, not on the Port object, we could put on on the driver object if necessary).

Does Driver know whether it's running under Cygwin or not? I didn't think it did.

> By that same logic, test_to_uri() is only used by the chromium Driver (and various pieces of test code), and should probably be moved out of the Port object and down into the chromium Driver.

It's also used by WebKitPort._command_from_driver_input, of course!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.