[Webkit-unassigned] [Bug 64468] WIN: DumpRenderTree hangs under NRWT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64468





--- Comment #13 from Adam Roben (:aroben) <aroben at apple.com>  2012-01-05 12:05:19 PST ---
(In reply to comment #11)
> Test names as passed to run_test() are expected to be relative-path filenames. We could centralize and standardize testing whether the test is an http test in a separate method on Port() if we wanted, but the change I suggested in comment #7 is correct for the cygwin platform. It would probably be good to change cygpath to be a no-op on non-cygpath platform just to be portable, or you could change the implementation to get an abspath and then only call cygpath if needed.
> 
> I would not go through the uri transformation; it's unnecessary and confusing.

Your proposed change in comment 7 isn't quite right: tests in http/tests/local are supposed to be loaded as local files, not as http: URLs. At least according to Port.test_to_uri.

It seems best to me to keep cygpath as-is. Having it be a no-op for most developers will most likely mean that it won't be used correctly.

I'm trying to come up with a good name for the concept of "path to test that the driver will understand" as opposed to "path to test that Python will understand". If we had such a name, we could have a Port.test_to_<name> function that would generate the right type of path.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.