[Webkit-unassigned] [Bug 75635] New: CSSValue could be packed better on windows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 5 11:19:43 PST 2012


           Summary: CSSValue could be packed better on windows
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Windows 7
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: tony at chromium.org
                CC: rniwa at webkit.org

>From CSSValue.h:

    // The bits in this section are only used by specific subclasses but kept here
    // to maximize struct packing.

    // CSSPrimitiveValue bits:
    unsigned char m_primitiveUnitType : 7; // CSSPrimitiveValue::UnitTypes
    mutable bool m_hasCachedCSSText : 1;
    bool m_isQuirkValue : 1;

    // CSSInitialValue bits:
    bool m_isImplicitInitialValue : 1;

    // CSSValueList bits:
    bool m_isSpaceSeparatedValueList : 1;

    unsigned char m_classType : ClassTypeBits; // ClassType

ClassTypeBits is 5 bits.  Swapping between bools and unsigned chars is bad for MSVC.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list