[Webkit-unassigned] [Bug 75553] [GTK][WK2] Initial FullScreen support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75553





--- Comment #13 from Philippe Normand <pnormand at igalia.com>  2012-01-05 08:24:51 PST ---
(In reply to comment #11)
> (From update of attachment 121276 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121276&action=review
> 
> > Source/WebKit2/UIProcess/gtk/FullScreenWindowController.cpp:64
> > +static gboolean onFullscreenGtkKeyPressEvent(GtkWidget* widget, GdkEventKey* event, FullScreenWindowController* controller)
> > +{
> > +    switch (event->keyval) {
> > +    case GDK_KEY_Escape:
> > +    case GDK_KEY_f:
> > +    case GDK_KEY_F:
> > +        controller->exitFullScreen();
> 
> This could be moved to webkitWebViewBaseKeyPressEvent(), checking whether it's in fullscreen or not, probably adding FullScreenWindowController::fullscreenEnabled().
> 

But it'd need to be guarded with ifdefs there. Sorry but I still prefer this self-contained approach of the FullScreenWindowController ;)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.