[Webkit-unassigned] [Bug 75454] Web Inspector: Add utility changes for Spectrum colorpicker

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75454





--- Comment #10 from Brian Grinstead <briangrinstead at gmail.com>  2012-01-05 05:57:29 PST ---
(In reply to comment #9)

> Now that I looked at the runtime, I think this is wrong. We never want popovers to be limited with the ancestor elements. When there is not enough real estate, we'd like them to be rendered say "to the left" of the anchor, which is outside the styles sidebar. So you should not need this change. Sorry for bringing it up so late.

I thought about this as well when first implementing it.  The issue that comes up though is that the popover 'sticks' to the location it was opened, even if the sidebar pane is scrolled or resized.  This didn't feel right to me.  The original popover component wasn't designed to be used in a scrolling panel as far as I can tell.  That, combined with the small constant size of the colorpicker I think makes sense to put it in the styles sidebar - essentially inserting it in the DOM next to the swatch it 'belongs' to.

Can you try commenting out the line:
'this._popover.parentElement = container;'
from https://bugs.webkit.org/show_bug.cgi?id=71262 and tell me if you still think it is preferable?  Make sure you scroll after opening a colorpicker.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.