[Webkit-unassigned] [Bug 75553] [GTK][WK2] Initial FullScreen support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 5 02:14:11 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=75553





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-01-05 02:14:11 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > > Source/WebKit2/UIProcess/gtk/FullScreenWindowController.cpp:24
> > > +#include "FullScreenWindowController.h"
> > 
> > I think we can avoid this object and move the implementation to WebKitWebViewBase
> > 
> 
> Not sure, if we plan to implement the animation if might be better to keep this code contained in a separate class.

I prefer to keep it simple now and add the complexity later if we end up implementing the animation. But if you are sure we will need this object sooner or later, it's ok for me to add it now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list