[Webkit-unassigned] [Bug 72017] [EFL] Replace alloca to C++ new placement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72017


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #121226|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #14 from Andreas Kling <kling at webkit.org>  2012-01-05 00:10:44 PST ---
(From update of attachment 121226)
View in context: https://bugs.webkit.org/attachment.cgi?id=121226&action=review

r=me

> Source/WebCore/platform/efl/ScrollbarEfl.cpp:164
> -    Edje_Message_Float_Set* message = static_cast<Edje_Message_Float_Set*>
> -        (alloca(sizeof(Edje_Message_Float_Set) + sizeof(float)));
> +    char buffer[sizeof(Edje_Message_Float_Set) + sizeof(double)];
> +    Edje_Message_Float_Set* message = reinterpret_cast<Edje_Message_Float_Set*>(buffer);

Please note in the ChangeLog why you are changing from float to double.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.