[Webkit-unassigned] [Bug 75171] NULL ptr in WebCore::TextIterator::rangeFromLocationAndLength

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 4 16:05:46 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=75171





--- Comment #5 from Pablo Flouret <pablof at motorola.com>  2012-01-04 16:05:46 PST ---
(In reply to comment #4)
> (From update of attachment 121168 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121168&action=review
> 
> >>> Source/WebCore/editing/ApplyBlockElementCommand.cpp:84
> >>> +    if (startOfSelection.isNull() || endOfSelection.isNull())
> >> 
> >> You should just call isNonOrphanedCaretOrRange on selection.
> > 
> > That's called at the start of the function and it returns true. If i understand things correctly, it's not orphaned, it's just that there's a single element but it's not selectable due to the -webkit-user-select css declaration.
> > 
> > A similar bug is https://bugs.webkit.org/show_bug.cgi?id=26214
> 
> selectionForParagraphIteration is probably returning a null selection. isNonOrphanedCaretOrRange checks nullness as well as orphanedness.

selectionForParagraphIteration seems to deal with tables, and there are none here, i checked the value of selection.isNonOrphanedCaretOrRange() in the debugger anyway and it's true at that point also.

The selection is not null itself, selection.visible{Start,End} are the ones returning null positions due to no available selectable elements (from my guess given above).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list