[Webkit-unassigned] [Bug 75569] New: DOM Attribute tests on Dromaeo spends 2.7% of time in hasSelectorForAttribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75569

           Summary: DOM Attribute tests on Dromaeo spends 2.7% of time in
                    hasSelectorForAttribute
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML DOM
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: darin at apple.com, oliver at apple.com, koivisto at iki.fi,
                    kling at webkit.org


Go to http://dromaeo.com/?dom and profiled WebKit r103959 while it was running DOM Attributes tests.

Besides AtomicString::addSlowCase which accounts for about 12% of time, we spend 2.7% of time in hasSelectorForAttribute. We can probably use bloom filter there as anttik suggested.

    6.6%    6.6%    JavaScriptCore    JSC::IdentifierTable::add(WTF::StringImpl*)
    5.8%    5.8%    JavaScriptCore    WTF::AtomicString::addSlowCase(WTF::StringImpl*)
    5.1%    5.1%    WebCore    WTF::HashTableIterator<WTF::StringImpl*, std::pair<WTF::StringImpl*, JSC::Weak<JSC::JSString> >, WTF::PairFirstExtractor<std::pair<WTF::StringImpl*, JSC::Weak<JSC::JSString> > >, WTF::StringHash, WTF::PairHashTraits<WTF::HashTraits<WTF::StringImpl*>, WTF::HashTraits<JSC::Weak<JSC::JSString> > >, WTF::HashTraits<WTF::StringImpl*> > WTF::HashTable<WTF::StringImpl*, std::pair<WTF::StringImpl*, JSC::Weak<JSC::JSString> >, WTF::PairFirstExtractor<std::pair<WTF::StringImpl*, JSC::Weak<JSC::JSString> > >, WTF::StringHash, WTF::PairHashTraits<WTF::HashTraits<WTF::StringImpl*>, WTF::HashTraits<JSC::Weak<JSC::JSString> > >, WTF::HashTraits<WTF::StringImpl*> >::find<WTF::IdentityHashTranslator<WTF::StringHash>, WTF::StringImpl*>(WTF::StringImpl* const&)
    0.0%    5.0%    WebCore     WebCore::jsString(JSC::ExecState*, WTF::String const&)
    0.0%    0.1%    WebCore     WebCore::jsHTMLElementId(JSC::ExecState*, JSC::JSValue, JSC::Identifier const&)
    0.0%    0.0%    WebCore     WebCore::jsStringOrNull(JSC::ExecState*, WTF::String const&)
    3.5%    3.5%    WebCore    WebCore::JSHTMLElement::getOwnPropertySlot(JSC::JSCell*, JSC::ExecState*, JSC::Identifier const&, JSC::PropertySlot&)
    3.5%    3.5%    JavaScriptCore    JSC::MarkedBlock::sweep(JSC::MarkedBlock::SweepMode)
    3.1%    3.1%    Unknown Library    0x2becb9401640 [23.2KB]
    2.9%    2.9%    JavaScriptCore    JSC::JSValue::toPrimitiveString(JSC::ExecState*) const
    2.7%    2.7%    WebCore    bool WTF::HashTable<WTF::AtomicStringImpl*, WTF::AtomicStringImpl*, WTF::IdentityExtractor, WTF::PtrHash<WTF::AtomicStringImpl*>, WTF::HashTraits<WTF::AtomicStringImpl*>, WTF::HashTraits<WTF::AtomicStringImpl*> >::contains<WTF::IdentityHashTranslator<WTF::PtrHash<WTF::AtomicStringImpl*> >, WTF::AtomicStringImpl*>(WTF::AtomicStringImpl* const&) const
    0.0%    2.7%    WebCore     WebCore::CSSStyleSelector::hasSelectorForAttribute(WTF::AtomicString const&) const
    0.0%    2.7%    WebCore      WebCore::Element::recalcStyleIfNeededAfterAttributeChanged(WebCore::Attribute*)
    0.0%    2.7%    WebCore       WebCore::StyledElement::attributeChanged(WebCore::Attribute*, bool)
    0.0%    2.7%    WebCore        WebCore::Element::didModifyAttribute(WebCore::Attribute*)
    0.0%    1.8%    WebCore         WebCore::Element::setAttribute(WebCore::QualifiedName const&, WTF::AtomicString const&)
    0.0%    1.0%    WebCore         WebCore::Element::setAttribute(WTF::AtomicString const&, WTF::AtomicString const&, int&)
    0.0%    0.0%    WebCore     WebCore::Element::recalcStyleIfNeededAfterAttributeChanged(WebCore::Attribute*)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.