[Webkit-unassigned] [Bug 68578] WinLauncher fails to launch when double-clicked

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68578





--- Comment #5 from Adam Roben (:aroben) <aroben at apple.com>  2012-01-04 11:29:20 PST ---
(From update of attachment 121128)
View in context: https://bugs.webkit.org/attachment.cgi?id=121128&action=review

>>> Tools/WinLauncher/WinLauncherLauncherResource.h:1
>>> +//{{NO_DEPENDENCIES}}
>> 
>> One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
> 
> Should have a space between // and comment  [whitespace/comments] [4]

This file is auto-generated by VS.

>> Tools/win/DLLLauncher/DLLLauncherMain.cpp:33
>> +#include <string>
> 
> Alphabetical sorting problem.  [build/include_order] [4]

I'm not sure what our standard style is for headers like <string>. I guess I'll sort them normally.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.