[Webkit-unassigned] [Bug 72589] [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72589





--- Comment #16 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-01-04 08:22:58 PST ---
(In reply to comment #15)
> Thanks for the suggestion and the code snippet Carlos. However I have a doubt: do you think this solution (using another thread to kill the main one on timeout) is better/cleaner than the current approach?

Yes, I think so, and it's less error prone. For example your patch doesn't handle EINTR when reading, I think it should use select, since the descriptor is non-blocking to know when to read, and it's leaking the stdout desriptor that should be closed after reading. All of that (and more) is correctly handled by g_spawn_sync() and you have the output directly in a variable. But I'm fine with your solution (fixing the problems I mentioned) if you think it's better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.