[Webkit-unassigned] [Bug 75466] Remove style warning in GraphicsContext3DOpenGL.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 3 18:20:35 PST 2012


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #120923|review?                     |review-
               Flag|                            |

--- Comment #3 from Daniel Bates <dbates at webkit.org>  2012-01-03 18:20:35 PST ---
(From update of attachment 120923)
View in context: https://bugs.webkit.org/attachment.cgi?id=120923&action=review

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:887
>      // FIXME: This is not implemented on desktop OpenGL. We need to have ifdefs for the different GL variants

Nit: This comment is missing a period at the end of the line. Comments should be full sentences as per the WebKit style guide.

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:889
> +    // ::glReleaseShaderCompiler();

We shouldn't commit commented out code. Instead of fixing the style issue on this line, I suggest we remove this line entirely because it's commented out code and it's clear from the name of this method (whose name coincides with a similarly named OpenGL call) that the implementation of this method will need to inform OpenGL to deallocate its internal resources associated with the shader compiler.

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:1276
> +        // Let OpenGL handle these.

This comment is inane as it doesn't explain "why" we should use OpenGL handle these cases. Either we should improve this comment or remove it.

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:1310
> +        return "";

It is sufficient to call the default String() constructor here instead of the C-string variant:

return String();

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:1318
> +            return "";


> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:1321
> +        GLchar* info = (GLchar*) fastMalloc(length);

Can we use OwnArrayPtr here? Then we can get rid of the fastFree() call on line 1326.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list