[Webkit-unassigned] [Bug 26139] Implement onredo and onundo event handlers

Tue Jan 3 09:38:13 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=26139

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120933|review?                     |review-
               Flag|                            |

--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2012-01-03 09:38:13 PST ---
(From update of attachment 120933)
View in context: https://bugs.webkit.org/attachment.cgi?id=120933&action=review

> LayoutTests/editing/undo/b26139.html:3
> +
> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> +<html xmlns="http://www.w3.org/1999/xhtml">

This is definitely not a XHTML 1.0 as onundo/onredo content attributes are not defined in XHTML1.0.

> LayoutTests/editing/undo/b26139.html:15
> +		function()
> +		{
> +			alert( 'The "redo" event has been fired!' );
> +		});

Wrong indentation.

> LayoutTests/editing/undo/b26139.html:22
> +		function()
> +		{
> +			alert( 'The "undo" event has been fired!' );
> +		});
> +

Ditto.

> LayoutTests/editing/undo/b26139.html:30
> +RandomText: <input type="text" name="randomText" /><br />

This test doesn't do anything. And you're also not adding an expected result. r- due to this. Please see http://trac.webkit.org/wiki#LayoutTests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.