[Webkit-unassigned] [Bug 26139] Implement onredo and onundo event handlers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26139





--- Comment #3 from Peter Beverloo <peter at chromium.org>  2012-01-03 08:00:49 PST ---
(From update of attachment 120933)
View in context: https://bugs.webkit.org/attachment.cgi?id=120933&action=review

Just some drive-by nits, thanks!

> ChangeLog:10
> +

No need to edit this file, it are (presumably local) svn:ignore changes irrelevant to this patch.

> Source/JavaScriptCore/ChangeLog:11
> +

Dito.

> Source/WebCore/ChangeLog:11
> +        * dom: Added property svn:ignore.

Dito with the svn:ignore items in this list.

> Source/WebKit/gtk/ChangeLog:9
> +

This ChangeLog also only contains an svn:ignore property change.

> LayoutTests/ChangeLog:3
> +        https://bugs.webkit.org/show_bug.cgi?id=26139

It'd be great if you could include a title here. As a nit for the filename: I would personally prefer a name such as "onundo-onredo-events.html" over "b26139.html" and refer to the bug in an HTML comment within the test-case.

> LayoutTests/editing/undo/b26139.html:34
> +

Using window.execCommand it should be possible to make an automated test for this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.