[Webkit-unassigned] [Bug 75467] [GTK] Fix scrollbars size with GTK+ 3.x

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 3 03:36:56 PST 2012


--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-01-03 03:36:57 PST ---
(In reply to comment #2)
> (From update of attachment 120925 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=120925&action=review
> I think I would just have one call to gtk_widget_path_iter_add_class and set the right style class to a variable in the ifs, but other than that it looks OK to me.

Ok, I'll change that.

> There are no tests that need updating because of this?

hmm, I guess this might break tests using scrolbars for example.

> > Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:92
> > +        gtk_widget_path_iter_add_class(path, 0, "arrow");
> I suppose this does not use GTK_STYLE_CLASS_ARROW because it was added later?

Yes, it didn't exist, I'm not sure if it exists now or when it was added.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list