[Webkit-unassigned] [Bug 75454] Web Inspector: Add utility changes for Spectrum colorpicker

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 2 23:37:39 PST 2012


--- Comment #2 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2012-01-02 23:37:38 PST ---
(From update of attachment 120902)
View in context: https://bugs.webkit.org/attachment.cgi?id=120902&action=review

looks good but for the comments

> Source/WebCore/inspector/front-end/Popover.js:61
> +    

odd change

> Source/WebCore/inspector/front-end/Popover.js:93
> +        this._parentElement = parentElement;

Should this re-parent the popover when it is visible?

> Source/WebCore/inspector/front-end/utilities.js:916
> +function stopPropagation(e) {

Not sure if this is too useful. Pavel can comment on this

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list