[Webkit-unassigned] [Bug 73773] [WK2][GTK] WebSettings support in MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73773


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120887|review?                     |review+
               Flag|                            |




--- Comment #12 from Martin Robinson <mrobinson at webkit.org>  2012-01-02 10:16:48 PST ---
(From update of attachment 120887)
View in context: https://bugs.webkit.org/attachment.cgi?id=120887&action=review

Looks good, but please consider the following cleanup before landing...

> Tools/MiniBrowser/gtk/main.c:30
>  #include <webkit2/webkit2.h>

I know it was wrong before, but do you mind making sure that this is in alphabetical order now?

> Tools/MiniBrowser/gtk/main.c:45
> +static void loadURI(const gchar *uri, WebKitSettings *webkitSettings)

Please rename this to something like createBrowserWindow.

> Tools/MiniBrowser/gtk/main.c:88
> +        gboolean propertyValue = TRUE;
> +        if (value && g_ascii_strcasecmp(value, "true") && strcmp(value, "1"))
> +            propertyValue = FALSE;

This can just be: 

gboolean propertyValue = !(value && g_ascii_strcasecmp(value, "true") && strcmp(value, "1"));

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.