[Webkit-unassigned] [Bug 73309] [Qt] GC should be parallel on Qt platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73309





--- Comment #26 from Balazs Kelemen <kbalazs at webkit.org>  2012-01-02 07:02:02 PST ---
(From update of attachment 120875)
View in context: https://bugs.webkit.org/attachment.cgi?id=120875&action=review

Informal review.
Some nits, otherwise looks good to me.

> Source/JavaScriptCore/GNUmakefile.list.am:607
> +        Source/JavaScriptCore/wtf/NumberOfCores.h \
> +        Source/JavaScriptCore/wtf/NumberOfCores.cpp \

Nit: wrong identation

> Source/JavaScriptCore/wtf/MainThread.cpp:263
> +#if ENABLE(PARALLEL_GC)
> +static ThreadSpecific<bool>* isGCThread;
> +
> +void initializeGCThreads()
> +{
> +    isGCThread = new ThreadSpecific<bool>();
> +}
> +#endif
> +
> +#if ENABLE(PARALLEL_GC)
> +void registerGCThread()
> +{

Nit: no need for the #endif+#if again, please remove them.

> Source/JavaScriptCore/wtf/NumberOfCores.cpp:46
> +    if (s_numberOfCores > 0)
> +        return s_numberOfCores;

Nit: I would put a newline after that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.