[Webkit-unassigned] [Bug 74993] [EFL] Refactor the way using cairo in ewk_tiled_backing_store.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74993





--- Comment #16 from Tomasz Morawski <t.morawski at samsung.com>  2012-01-02 05:51:11 PST ---
(In reply to comment #14)
> (In reply to comment #13)
> > (In reply to comment #12)
> > > (From update of attachment 120572 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=120572&action=review
> > > 
> > > > Source/WebKit/efl/ewk/ewk_view_tiled.cpp:28
> > > > +#include <RefPtrCairo.h>
> > > 
> > > Awesome, I love seeing smart pointers being used :) I don't think you need reference counting in this case, though. Isn't an OwnPtr enough?
> > 
> > Hi, Kubo.
> > 
> > I am glad that you review my patch. :)
> > Let me check your idea.
> 
> Kubo,
> 
> Unfortunately, OwnPtrCairo doesn't seem to support cairo_t and cairo_surface_t.
> Fortunately, One of my colleague (Tomasz) is wanting to add new code into OwnPtrCairo.
> After Tomasz's new patch will be applied, I will replace RefPtr with OwnPtr.
Hi,
Finally. All cairo object should not be wrapped in an OwnPtr because it's reference counted internally. This is way there is no implementation for basic cairo_t object in OwnPtr. We should stay with RefPtr version of Kwang's patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.