[Webkit-unassigned] [Bug 68509] [EFL] Implementation of Unit Tests framework for the WebKit-Efl port

Sun Jan 1 16:25:06 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=68509

--- Comment #14 from Raphael Kubo da Costa <kubo at profusion.mobi>  2012-01-01 16:25:06 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > I would also prefer to use as many "native" C++ and WebKit types as possible, so you have bool instead of Eina_Bool where possible, and you use Strings instead of char*'s whose memory you need to manage manually. Speaking of memory management, you could also use OwnPtrs for the Evas_Objects and other pointers so you also don't need to manage their memory by hand.
> 
> I think it might be a problem using WebKit's OwnPtrs in unit tests context.
> Tests are linked against WebKit library. Those internals like OwnPtr are not publicly exported.

>From the latest patch in bug 68510, the tests actually link against WebCore, JSC and many other libraries, so there should be no problem with using OwnPtr's.

> Other way I am not sure if is a good idea to mix Evas_Object's with smart pointers. How do you think ?

What problems do you see? It is already done in other places in ewk and EFL's DumpRenderTree.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.