[Webkit-unassigned] [Bug 75397] MathML code clean-up

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75397





--- Comment #3 from Dave Barton <dbarton at mathscribe.com>  2012-01-01 09:53:10 PST ---
Alexey, thanks for your feedback (seriously). I do plan to do a lot of subsequent work in the rendering/mathml files, fixing a lot of bugs. I started by reporting and fixing several small bugs, and am now working on the first much larger one. I submitted this patch first though, following http://trac.webkit.org/wiki/CodeReview and http://trac.webkit.org/wiki/Creating%20and%20Submitting%20Layout%20Tests%20and%20Patches advice. I think my next patch will be easier to review if this one is done first. Perhaps I should create a bug for it now and say this bug blocks it? Any advice you can give me would be helpful, as I am new to WebKit.

As for "} // namespace WebCore", I was just trying to make the rendering/mathml files more consistent. 72 of the 99 *.cpp files in WebKit/Source/WebCore/rendering/ contain this exact string. But I'm happy to skip this or other clean-up if it'd make it easier for other WebKit developers. It seems the important thing is to make subsequent major bug-fix patches easier to review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.