[Webkit-unassigned] [Bug 78570] [DRT] Remove all PlainTextController usages in existing tests by adding internal API.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 29 16:12:44 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=78570





--- Comment #30 from Kangil Han <kangil.han at samsung.com>  2012-02-29 16:12:34 PST ---
(In reply to comment #28)
> (From update of attachment 129423 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=129423&action=review
> 
> What about removing PlainTextController now, since it's not used any more?
> IMHO keeping it can only result in new tests, not supported by EFL DRT.

Okay, I will create a new bug to remove source code related to PlainTextController in other ports.

> 
> > Source/WebCore/ChangeLog:11
> > +        No new tests because this patch just modified existing test cases
> 
> IMHO this line added no additional value. Maybe sth like "Changed test to use internals.rangeAsText" is better.

Done. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list