[Webkit-unassigned] [Bug 79873] [BlackBerry] Upstream LayerCompositingThread.{h, cpp}

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79873


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #129415|review?                     |review-
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-02-29 11:08:50 PST ---
(From update of attachment 129415)
View in context: https://bugs.webkit.org/attachment.cgi?id=129415&action=review

Not much wrong, but still some cleanup to do.

> Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.cpp:297
> +        FloatQuad surfaceQuad = getTransformedRect(m_bounds, IntRect(IntPoint(), m_bounds), drawTransform);

Better use IntPoint::zero

> Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.cpp:487
> +    if (layer)

Can combine these two lines.

> Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.cpp:679
> +        ASSERT_NOT_REACHED();

Can combine with AnimatedPropertyBackgroundColor case, they do the same.

> Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.h:47
> +class SkBitmap;

Not used? Please clean it up and the includes above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.