[Webkit-unassigned] [Bug 79703] [chromium] Fix fast/regex/overflow.html after r108999

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79703





--- Comment #8 from Adrienne Walker <enne at google.com>  2012-02-29 10:10:09 PST ---
(In reply to comment #7)
> (In reply to comment #5)
> > > As you pointed out, the rebaselining would make sense.
> > 
> > I find it very strange to rebaseline a test to include a FAIL line.
> > 
> > If this test behavior is not supposed to be cross-port, maybe it should go into LayoutTests/platform/mac.
> 
> Yes. By "rebaseline", I meant, we should put the Chromium result to LayoutTests/platform/chromium/fast/regex/overflow-expected.txt. Then, mac/gtk/qt/... will lookup LayoutTests/fast/regex/overflow-expected.txt and Chromium will lookup LayoutTests/platform/chromium/fast/regex/overflow-expected.txt.

I think I understand what you're saying.

I just find it strange to check in a Chromium-specific baseline into LayoutTests/platform/chromium/fast/regex/overflow-expected.txt that includes a FAIL line.  There's a difference between a port-specific expectation of "this test passes, but has slightly different pixels or text" and "this test says it fails".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.