[Webkit-unassigned] [Bug 17450] in page anchor and keyboard navigation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=17450


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #129465|                            |review?
               Flag|                            |




--- Comment #16 from Mario Sanchez Prada <msanchez at igalia.com>  2012-02-29 09:59:56 PST ---
Created an attachment (id=129465)
 --> (https://bugs.webkit.org/attachment.cgi?id=129465&action=review)
Patch proposal + Layout Test

Attaching a patch that addresses the issue in a cross-platform way: I moved AXObjectCache::handleScrolledToAnchor() from AXObjectMac.mm and AXObjectGTK.cpp out to AXObjectCache.cpp and implemented there the fix.

However, as win and chromium ports already provide their own implementation of that function (which are different among them) I dare not to remove that code and so I put the new function in AXObjectCache.cpp inside a #if PLATFORM(GTK) || PLATFORM(MAC) -- #endif section. In the future if the people from those ports want to use the cross-platform solution, it would be an easy change.

Last, I wrote a layout test that I think should work fine both in GTK and Mac but, as usual, no promises yet :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.