[Webkit-unassigned] [Bug 79896] [CMake][DRT] Add WebCoreTestSupport

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79896


Patrick R. Gansterer <paroga at paroga.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #129428|review?                     |review-
               Flag|                            |




--- Comment #2 from Patrick R. Gansterer <paroga at paroga.com>  2012-02-29 03:27:31 PST ---
(From update of attachment 129428)
View in context: https://bugs.webkit.org/attachment.cgi?id=129428&action=review

> Source/WebCore/ChangeLog:11
> +        No new tests - just CMake changes for DRT.

IMO including this line makes no sense (it adds so additional info), but it's ok to keep it.

> Source/WebCore/CMakeLists.txt:2539
> +    INSTALL(TARGETS ${WebCore_LIBRARY_NAME} ${WebCoreTestSupport_LIBRARY_NAME} DESTINATION lib)

do you really want to INSTALL WebCoreTestSupport?

> Source/WebCore/UseJSC.cmake:281
> +    LIST(APPEND IDL_FILES_LIST "${IDL_FILES_LIST}${WEBCORE_DIR}/${_idl}\n")

no need for LIST(APPEND), you set the variable with a value already including the old value.

> Source/WebCore/UseV8.cmake:267
> +    LIST(APPEND IDL_FILES_LIST "${IDL_FILES_LIST}${WEBCORE_DIR}/${_idl}\n")

LIST(APPEND) -> SET()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.