[Webkit-unassigned] [Bug 79768] ShadowTree::recalcShadowTreeStyle only updates the youngest tree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79768





--- Comment #3 from Shinya Kawanaka <shinyak at chromium.org>  2012-02-28 23:59:43 PST ---
(In reply to comment #2)
> Searching youngestShadowRoot(), it turns out some other functions
> like following is also need to be multiple-shadow-aware.
> 
> - bool ShadowTree::needsStyleRecalc()  
> - bool ShadowTree::childNeedsStyleRecalc() 
> - bool ShadowTree::needsReattachHostChildrenAndShadow()
> - void ShadowTree::hostChildrenChanged()  
> - void TreeScopeAdopter::moveTreeToNewScope(Node* root)
> - void TreeScopeAdopter::moveTreeToNewDocument(Node* root, Document* oldDocument, Document* newDocument) const

I think we should consider multiple shadow subtrees for needsStyleRecalc() and childNeedsStyleRecalc(),
but not for needsReattachHostChildrenAndShadow() and needsReattachHostChildrenAndShadow(),
because the latter methods checks the existence of InsertionPoint of the youngest shadow roots. If there is no insertion point in the youngest shadow root, older shadow subtrees or light children won't be rendered al all.
If this assumption is wrong, please let me know...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.