[Webkit-unassigned] [Bug 78473] ShadowRoot needs innerHTML

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78473


MORITA Hajime <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #129397|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #24 from MORITA Hajime <morrita at google.com>  2012-02-28 23:37:49 PST ---
(From update of attachment 129397)
View in context: https://bugs.webkit.org/attachment.cgi?id=129397&action=review

> Source/WebCore/editing/markup.h:30
> +#include "ExceptionCode.h"

You can just typedef int ExceptionCode. instead of including this.
Same for ContainerNode.h.
Less includes are better.

> LayoutTests/platform/mac/Skipped:426
> +fast/dom/shadow

Please don do this unless you are a maintainer of this port. 
There some test which can run without ENABLE_SHADOW_DOM under shadow/
We should've splited these from one which needs API. But it's another story.

> LayoutTests/platform/qt/Skipped:162
> +fast/dom/shadow

Ditto.

> LayoutTests/platform/win/Skipped:1452
> +fast/dom/shadow

Ditto.

> LayoutTests/platform/wincairo/Skipped:1968
>  

Ditto.

> LayoutTests/platform/wk2/Skipped:1066
> +fast/dom/shadow

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.