[Webkit-unassigned] [Bug 79759] [EFL] Implementation of missing functions in GraphicsContext3DPrivate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79759





--- Comment #4 from Hyowon Kim <hw1008.kim at samsung.com>  2012-02-28 21:19:17 PST ---
(In reply to comment #2)
> (From update of attachment 129204 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=129204&action=review
> LGTM, except a couple of nitpicks - please fix before committing.
> > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:434
> > +    if (m_syntheticErrors.size() > 0) {
> Use .isEmpty()
> > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:463
> > +        *value /= 4;
> Comment for why this is /4

It's a really important finding!

I was a little confused about OpenGL ES 2 compliance.

Evas_GL offers the OpenGL ES 2 interface, so I removed codes for desktop-GL in getIntegerv() like GraphicsContext3DOpenGLES.cpp.

Please review this modification again. Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.