[Webkit-unassigned] [Bug 79856] <msubsup> setNeedsLayout() correction

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79856





--- Comment #2 from Julien Chaffraix <jchaffraix at webkit.org>  2012-02-28 19:11:29 PST ---
(From update of attachment 129376)
View in context: https://bugs.webkit.org/attachment.cgi?id=129376&action=review

> Source/WebCore/ChangeLog:10
> +        superscriptWrapper->setNeedsLayout(true, false); in the last patch actually needs to be
> +        superscriptWrapper->setNeedsLayout(true); in order to mark its parent, m_scripts, as
> +        needing layout also.

I would rather see a patch with your parent marked in this case. As I told you calling setNeedsLayout(true, true) during layout is really something you don't want to do. That is unless you want to open a security can of worms.

> Source/WebCore/ChangeLog:12
> +        No new tests. It's actually difficult to test the need for this with the current code,

I would really love to see a test for 2 reasons:
* this would help your future refactorings.
* this will give some confidence that the code is properly tested.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.