[Webkit-unassigned] [Bug 78028] Decouple scrollbar painting from Scrollbar object

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78028





--- Comment #42 from James Robinson <jamesr at chromium.org>  2012-02-28 12:31:27 PST ---
(From update of attachment 128880)
View in context: https://bugs.webkit.org/attachment.cgi?id=128880&action=review

I think this looks pretty good.  Two comments below that will make this easier to understand fully.

> Source/WebCore/platform/Scrollbar.cpp:115
> +void Scrollbar::setFrameRect(const IntRect& rect)

nit: would you mind not moving the defintions of this functions around in this .cpp in this patch? it makes it very hard to tell what code is actually changing and what is not

> Source/WebCore/platform/ScrollbarThemeClient.h:42
> +    virtual ~ScrollbarThemeClient() { }

Is it possible to make this d'tor protected?  In other words, are there bits of code in the ScrollbarTheme classes relying on ScrollbarThemeClient pointers for lifetime management / ownership or do they simply need a view into the Scrollbar's state?  I think if we can make this d'tor protected it would be a big improvement to the general readability of the Scrollbar code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.