[Webkit-unassigned] [Bug 79811] Reimplement pathFromFont() in SimpleFontDataMac.mm

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79811


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #129296|review?                     |review+
               Flag|                            |




--- Comment #2 from mitz at webkit.org  2012-02-28 11:30:53 PST ---
(From update of attachment 129296)
View in context: https://bugs.webkit.org/attachment.cgi?id=129296&action=review

OK. I think you could have just as well removed this function and changed its callers.

> Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:85
> +static NSString* pathFromFont(NSFont* font)

Spaces should go before the star in Objective-C objects (I know this was already wrong in some of this code).

> Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:87
> +    return [[[font fontDescriptor] objectForKey:(NSString*)kCTFontURLAttribute] path];

Needs a space before the *.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.