[Webkit-unassigned] [Bug 79775] [GTK] Inconsistent state of WebKitWebView when replacing content in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79775





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-02-28 10:06:18 PST ---
(In reply to comment #3)
> (From update of attachment 129225 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=129225&action=review
> 
> Looks good. Please consider the minor cleanups below.
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:82
> > +    NoReplaceContent,
> 
> NotReplacingContent?

Sounds good.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:703
> > -    if (webView->priv->replacingContent) {
> > +    if (webView->priv->replaceContentStatus == ReplacingContent) {
> >          if (loadEvent == WEBKIT_LOAD_FINISHED)
> > -            webView->priv->replacingContent = false;
> > +            webView->priv->replaceContentStatus = DidReplaceContent;
> >          return;
> >      }
> >  
> > +    if (loadEvent == WEBKIT_LOAD_STARTED) {
> > +        if (webView->priv->replaceContentStatus == WillReplaceContent) {
> > +            webView->priv->replaceContentStatus = ReplacingContent;
> > +            return;
> > +        }
> > +        webView->priv->replaceContentStatus = NoReplaceContent;
> > +    }
> 
> Mind moving this to a helper called updateReplaceContentStatus?

Sure

> > Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp:148
> > +void WebViewTest::waitUntilTitleChanged(const char* expectedTitle)
> 
> Probably better to call this waitUntilTitleChangedTo.

I didn't add the 'To' because you can pass NULL to wait until title is changed to whatever thing. maybe it's better to use a default value of NULL, though

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.