[Webkit-unassigned] [Bug 79759] [EFL] Implementation of missing functions in GraphicsContext3DPrivate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79759


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #129204|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-02-28 07:39:27 PST ---
(From update of attachment 129204)
View in context: https://bugs.webkit.org/attachment.cgi?id=129204&action=review

LGTM, except a couple of nitpicks - please fix before committing.

> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:434
> +    if (m_syntheticErrors.size() > 0) {

Use .isEmpty()

> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:463
> +        *value /= 4;

Comment for why this is /4

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.