[Webkit-unassigned] [Bug 79673] Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79673





--- Comment #4 from Gustavo Noronha (kov) <gns at gnome.org>  2012-02-28 04:41:55 PST ---
(From update of attachment 129203)
View in context: https://bugs.webkit.org/attachment.cgi?id=129203&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:136
> +    command = ["perl", "./Tools/Scripts/update-webkit-libs-jhbuild --gtk"]

How about this: instead of removing update-webkitgtk-libs, keep it as a thin wrapper that calls update-webkitlibs-jhbuild with --gtk? The name of the script seems to be wrong here, btw, there's a dash between webkit and libs. By keeping the update-webkitgtk-libs script you can just remove this change, though.

> Tools/Scripts/update-webkitlibs-jhbuild:56
> +print "Updating GTK+ port dependencies using jhbuild...\n";

You probably want to change GTK+ in here by a variable set in the platform check above?

> Tools/Scripts/webkitdirs.pm:1825
> -    unshift(@buildArgs, "$sourceDir/Tools/gtk/run-with-jhbuild");
> +    unshift(@buildArgs, "--gtk");
> +    unshift(@buildArgs, "$sourceDir/Tools/jhbuild/run-with-jhbuild");

Same for this, I would prefer to keep gtk/run-with-jhbuild as a thin wrapper that calls the other one with the appropriate option.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.