[Webkit-unassigned] [Bug 79765] [Chromium] Layout Test webaudio/audiobuffersource-channels.html is failing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 28 01:42:06 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=79765





--- Comment #4 from Kenichi Ishibashi <bashi at chromium.org>  2012-02-28 01:42:06 PST ---
(In reply to comment #2)
> (In reply to comment #0)
> > The following layout test is failing on Debug builds
> > 
> > webaudio/audiobuffersource-channels.html
> > 
> > http://trac.webkit.org/changeset/109076 introduced the test. It tries to set more than 6 channels, but AudioNodeOutput doesn't allow more than 6 channels(from AudioNodeOutput.cpp):
> > 
> > // This is considering that 5.1 (6 channels) is the largest we'll ever deal with.
> > // It can easily be increased to support more if the web audio specification is updated.
> > const unsigned MaxNumberOfChannels = 6;
> > 
> > Looks like the test should set less than 6 channels for now.
> 
> how about remove the assert in AudioNodeOutput to support more than 6 channels in AudioNodeOutput?

The comment sounds reasonable to me, but I'm not familiar with webaudio stuff. I think you can ask the author to remove it. For now, I'd like to suggest updating the test to avoid crashes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list