[Webkit-unassigned] [Bug 78570] [DRT] Remove all PlainTextController usages in existing tests by adding internal API.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78570





--- Comment #20 from Patrick R. Gansterer <paroga at paroga.com>  2012-02-28 01:20:59 PST ---
(From update of attachment 129206)
View in context: https://bugs.webkit.org/attachment.cgi?id=129206&action=review

IMHO yhou should split this into a) Adding rangeAsText() and b) extend CMake files

> Source/WebCore/PlatformEfl.cmake:275
> +# EFL DRT needs use of WebCore/testing/Internals for testing purpose

Please move this stuff into the CMakeLists.txt as an additonal static library (with the name WebCoreTestSupport) and only link it when building DRT. WinApple port will need this too. I can post my current patch if you're interrested in it.

> Source/WebCore/PlatformEfl.cmake:299
> +    testing/js/WebCoreTestSupport.cpp
> +    testing/js/JSInternalsCustom.cpp

JSC specific -> preblems with V8 -> should go into UseJSC/UseV8.cmake

> Source/WebCore/PlatformEfl.cmake:329
> +        DEPENDS ${WEBCORE_DIR}/bindings/scripts/generate-bindings.pl ${SCRIPTS_BINDINGS} ${WEBCORE_DIR}/bindings/scripts/CodeGeneratorJS.pm ${EFL_ADDITIONAL_SUPPLEMENTAL_DEPENDENCY_FILE}

JSC specifc

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.