[Webkit-unassigned] [Bug 76816] Implement the URL decomposition IDL attributes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 28 00:50:05 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=76816





--- Comment #28 from Kaustubh Atrawalkar <kaustubh at motorola.com>  2012-02-28 00:50:04 PST ---
(In reply to comment #27)
> (From update of attachment 128723 [details])
> IMHO, we should dig through the history to understand why they're that way and we should test other browsers to see if they have the same differences.  This stuff requires careful study before being changed.

Hi Adam.

I have little study about all URL decomposition attributes used in Location & HTML Anchor Element. Here is the brief summary about the same -

1) Hash - getter function is same. Setter function has modified for Location by you in https://bugs.webkit.org/attachment.cgi?id=77735&action=prettypatch. This was changed for handling the case when fragment identifiers are invalid.
2) Protocol  - Both setter & getter functions are same.
3) Port  - getter functions is same. setter function for Location can have any number as port. But in case of HTMLAnchorElement it should be from DefaultPortsMap if protcol of the url is defined.
4) Hostname - Getter function is same. Setter function of HTMLAnchorElement has added checks for extra "/" but this is no more needed as KURL takes care of the same.
5) Host - Getter function is same. Setter function of HTMLAnchoreElement has added checks for ":" and port parsing. Again the same is taken care by KURL. not needed.
6) Pathname - Getter function is same. Setter functions of both classes have added check of "/". But no more needed as KURL has already taking care of the same.
7) Search - Getter function os same. Setter function for HTMLAnchorElement has extra check added for # but its already been added as FIXME for KURL.

I am trying to remove extrac checks from HTMLAnchorElement and test the debug build. So that both should be exactly same. Just in case of Port and Hash they both are different.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list