[Webkit-unassigned] [Bug 78570] [DRT] Remove all PlainTextController usages in existing tests by adding internal API.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78570





--- Comment #17 from Kangil Han <kangil.han at samsung.com>  2012-02-27 22:33:00 PST ---
(In reply to comment #16)
> (From update of attachment 129186 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=129186&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        As MORITA Hajime has recommended, this patch will remove all PlainTextController usages
> 
> It seems to me that "MORITA Hajime has recommended" is not unneeded in ChangeLog.
> 

Okay, I will remove those comments from ChangeLog

> > Source/WebCore/PlatformEfl.cmake:277
> > +# For details, please look at DumpRenderTreeChrome::onWindowObjectCleared function
> 
> Can't this test code be used by WinCE and Blackberry ? I think this code needs to be moved to WebCore/CMakeLists.txt

I don't think other ports like this idea because they have own way to include Source/WebCore/testing to their ports.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.