[Webkit-unassigned] [Bug 79599] webkit-gtk-1.7.90 fails to build testwebview for gtk2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79599


Alexandre Rostovtsev <tetromino at gentoo.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Alexandre Rostovtsev <tetromino at gentoo.org>  2012-02-27 22:18:03 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > Created an attachment (id=129178)
 --> (https://bugs.webkit.org/attachment.cgi?id=129178&action=review) [details] [details]
> > complete build log
> > 
> > (In reply to comment #1)
> > > This should be guarded by the GTK_API_VERSION2 define. This seems to be working properly for me. Can you build with "make V=1" and confirm that the macro is passed properly to the compiler?
> > 
> > The test fails to find gtk_box_new even though -DGTK_API_VERSION_2=1 is passed to the compiler:
> 
> This is quite odd, because those lines of code are:
> 
> #ifdef GTK_API_VERSION_2
>     GtkWidget *box = gtk_hbox_new(FALSE, 0);
> #else
>     GtkWidget *box = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, 0);
> #endif
> 
> I also double-checked the GTK+ 2.x compilation locally. It seemed to be compiling fine.

That's because that #ifdef was added only a few hours ago in svn by kov at webkit.org, see http://trac.webkit.org/changeset/108996/trunk/Source/WebKit/gtk/tests/testwebview.c

"compiling fine from svn trunk" != "compiling fine from webkitgtk.org tarball" ;)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.