[Webkit-unassigned] [Bug 77950] SSE optimization for vsvesq and vmaxmgv

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77950





--- Comment #17 from xingnan.wang at intel.com  2012-02-27 21:16:00 PST ---
(In reply to comment #16)
> Created an attachment (id=129183)
 --> (https://bugs.webkit.org/attachment.cgi?id=129183&action=review) [details]
> Patch

(In reply to comment #13)
> (From update of attachment 128852 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=128852&action=review
> 
> Except for the nit, looks good.
> 
> > Source/WebCore/platform/audio/VectorMath.cpp:500
> > +            source = _mm_and_ps(source, mMask);
> 
> nit: Perhaps add a comment here to say that anding the source with the mask computes the absolute value by making the sign bit 0 (positive).

The comment is add, thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.