[Webkit-unassigned] [Bug 79566] Fixed a typo in CanvasRenderingContext2D::drawImage(HTMLCanvasElement); incorrect source and destination rect used

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 27 15:34:44 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=79566


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #129112|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #15 from Daniel Bates <dbates at webkit.org>  2012-02-27 15:34:44 PST ---
(From update of attachment 129112)
View in context: https://bugs.webkit.org/attachment.cgi?id=129112&action=review

> Source/WebCore/ChangeLog:11
> +        I amended canvas-composite-canvas to cover this bug, and I also amended
> +        canvas-composite-image because I changed
> +        LayoutTests/fast/canvas/resources/canvas-composite-image-common.js.
> +        However, the change of canvas-composite-image is reasonable because
> +        drawImage(HTMLImageElement) will be able to have a similar bug.

Did you mean to use the same description in the WebCore change log? I suggest writing something specific to the WebCore change in this change log entry, like:
"Pass dstRect and bufferSrcRect to CanvasRenderingContext2D::fullCanvasCompositedDrawImage() for the destination and source rect, respectively."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list