[Webkit-unassigned] [Bug 79490] Percent width/height SVG not always scaled on window resize

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79490


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #129066|review?                     |review-
               Flag|                            |




--- Comment #6 from Nikolas Zimmermann <zimmermann at kde.org>  2012-02-27 11:51:18 PST ---
(From update of attachment 129066)
View in context: https://bugs.webkit.org/attachment.cgi?id=129066&action=review

Almost there, still some perf issues that should be resolved:

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1489
> +                if (relayoutChildren || box->hasRelativeLogicalWidth() || box->hasRelativeLogicalHeight())

Hm, I think you can now merge these two methods. no place needs either width or height information, all callers need both width and height info.
To avoid doing two virtual calls, just use hasRelativeDimensions() - this way you can also omit the logical everywhere, as it won't matter.

Note: You're also changing HTML behavior here, which is probably a bug fix. maxWidth/maxHeight is now included in this check. Needs a testcase.

> Source/WebCore/rendering/RenderBox.cpp:3967
> +

One newline too much.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.