[Webkit-unassigned] [Bug 53600] [GTK] Add support for window.runModalDialog

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53600





--- Comment #45 from Zan Dobersek <zandobersek at gmail.com>  2012-02-27 11:05:13 PST ---
(In reply to comment #44)
> (In reply to comment #43)
> > Exposing the dialog property in window features seems fine, but I don't think this makes it possible for the user to prevent creating a dialog web view. Is this even required/needed? Should we make displaying and running modal dialogs optional through some setting or just signal through ChromeClient::canRunModal that modal dialogs are always going to be run?
> 
> It seems extrememly useful for popup blocking and the like. Do other ports allow this?

The DOMWindow::showModalDialog function aborts if the DOMWindow does not allow popups, that is when 'javascript-can-open-windows-automatically' property on WebKitWebSettings is set to FALSE. That should be sufficient, no?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.