[Webkit-unassigned] [Bug 79566] Fixed a typo in CanvasRenderingContext2D::drawImage(HTMLCanvasElement); incorrect source and destination rect used
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 27 10:45:13 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=79566
Daniel Bates <dbates at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #129002|review?, commit-queue? |review-, commit-queue-
Flag| |
--- Comment #11 from Daniel Bates <dbates at webkit.org> 2012-02-27 10:45:13 PST ---
(From update of attachment 129002)
View in context: https://bugs.webkit.org/attachment.cgi?id=129002&action=review
This patch looks good to me, but we need a change log entry for the layout test changes.
You may also want to add a remark in the layout test change log entry that this patch only affects the results of LayoutTests/fast/canvas/canvas-composite-canvas.html and that the changes made to canvas-composite-image.html are a side effect of the change made to LayoutTests/fast/canvas/resources/canvas-composite-image-common.js.
> LayoutTests/ChangeLog:3
> + Fixed a typo of Canvas drawImage(canvas).
Nit: I updated the title of this bug to elaborate on the typo. For consistency, we should update this line to match the updated bug title. The updated title is a bit verbose. Feel free to come up with an alternative bug title.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list