[Webkit-unassigned] [Bug 78608] [BlackBerry] Dragging a selection handle outside of the content bounding box does not update the selection range correctly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 27 10:20:46 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=78608


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #129053|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #16 from Antonio Gomes <tonikitoo at webkit.org>  2012-02-27 10:20:46 PST ---
(From update of attachment 129053)
View in context: https://bugs.webkit.org/attachment.cgi?id=129053&action=review

> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:361
> +        targetPoint = IntPoint(targetPoint.x() < targetFrameRect.x() ? targetFrameRect.x() : std::min(targetPoint.x(), targetFrameRect.maxX()),
> +                targetPoint.y() < targetFrameRect.y() ? targetFrameRect.y() : std::min(targetPoint.y(), targetFrameRect.maxY()));

looks mis-indented.

> Source/WebKit/blackberry/WebKitSupport/DOMSupport.h:75
> +WebCore::IntPoint convertPointToFrame(const WebCore::Frame* sourceFrame, const WebCore::Frame* targetFrame, const WebCore::IntPoint& sourcePoint, const bool clampToTargetFrame = false);

'const' for the bool is uncommon, but that is ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list