[Webkit-unassigned] [Bug 77950] SSE optimization for vsvesq and vmaxmgv

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 27 09:19:55 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=77950





--- Comment #13 from Raymond Toy <rtoy at chromium.org>  2012-02-27 09:19:55 PST ---
(From update of attachment 128852)
View in context: https://bugs.webkit.org/attachment.cgi?id=128852&action=review

Except for the nit, looks good.

> Source/WebCore/platform/audio/VectorMath.cpp:500
> +            source = _mm_and_ps(source, mMask);

nit: Perhaps add a comment here to say that anding the source with the mask computes the absolute value by making the sign bit 0 (positive).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list